fix: preserve docs.json as cloud init source#335
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs.jsonwithoutdocs.config.*as the source of truth fordocs cloud init.docs.mode, runtime root, content roots, existing cloud feature choices, and existing docs-cloud extensions.docs.jsonwithout creating a nativedocs.config.tssidecar.docs cloud initruns idempotent for docs-json-only projects, even when Fumadocs dependencies/config files are present.Validation
pnpm --filter @farming-labs/docs exec vitest run src/cli/cloud.test.tspnpm --filter @farming-labs/docs typecheckpnpm exec oxlint packages/docs/src/cli/cloud.ts packages/docs/src/cli/cloud.test.tspnpm exec oxfmt --check packages/docs/src/cli/cloud.ts packages/docs/src/cli/cloud.test.ts && git diff --checkpnpm --filter @farming-labs/docs builddocs.config.tsx, frameworklessdocs.json, framework-backeddocs.jsonwithout config, fresh Fumadocs connect, fresh framework config creation, anddocs.jsonwith Fumadocs signals.Summary by cubic
Use an existing
docs.jsonas the source of truth fordocs cloud initwhen nodocs.config.*exists. Preserves frameworkless settings, writes cloud defaults todocs.json(nodocs.config.ts), and keeps repeat runs idempotent.docs.jsonas init input and writes defaults (apiKey env, deploy enabled, analytics) back to it.docs.mode, runtime/root, and content roots unchanged; subsequent runs are a no-op.Written for commit 96671cb. Summary will update on new commits.